Replace http-proxy server with BrowserSync proxy (docker development)
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make use of built in `browser-sync` proxy server within `gulpfile.js` - remove `G3W_PROXY_ROUTES` within `config.template.js`
|
@volterra79 before merging this let me know if I can also remove it as it project dependency within the Line 92 in 0308ffd |
Raruto
added
docs
- remove `src/assets/vendors/index.css.html` - remove `src/assets/vendors/index.js.html` - remove `src/index.dev.html` - rename `src/index.prod.html` into `src/index.html` - deprecate config.js variables (`distFolder`, `clientFolder`, `admin_static_folder`, `admin_templates_folder`) - add config.js variable: `admin_overrides_folder` - add gulpfile.js internal variable (`outputFolder`) in order to properly handle `dev` and `build` tasks
Raruto
commented
Aug 31, 2022
- add parameter `devConfig` within `config.template.js`
- deprecate parameter `createProject` within `config.template.js`
- deprecate parameter `seCCurrentProject` within `config.template.js`
- automatically toggle `skin-blue` class on body tag (dev environment)
- refactor function `ApplicationService::obtainInitConfig()`
- move `require('app/dev')` into `src/app/main.js` (application entry point)
- convert variable `G3W_PLUGINS` into array (list of locally developed plugins) - automatically assing `gid` and `baseurl` parameter for all locally developed plugins (ref: `src/app/dev/index.js`)
- add `gulp-sourcemaps` on production environment
make use of `transform` option instead of chaining transform methods
Raruto
commented
Sep 6, 2022
Raruto
changed the title
http-proxy server from gulpfile.jshttp-proxy server with BrowserSync proxy (dockerized developoment)
|
@volterra79 for me we are ready to merge this, so we can finally release v3.7.0-beta.0 |
# Conflicts: # gulpfile.js # src/assets/vendors/index.css.html # src/assets/vendors/index.js.html
…-sync-proxy # Conflicts: # gulpfile.js
…has the same color in production
…w_admin folder and not to plugins
Raruto
commented
Jan 10, 2023
Raruto
commented
Jan 10, 2023
…oup, type and id parameters to get initial configuration from g3w-admin server
volterra79
added a commit
that referenced
this pull request
Jan 11, 2023
…ent) (#150) * Remove `http-proxy` server - make use of built in `browser-sync` proxy server within `gulpfile.js` - remove `G3W_PROXY_ROUTES` within `config.template.js` * update development URLs within `readme.md` * Fix wrong merge * Proxy routes fallback within `config.template.js` (v3.x) * remove gulp task `plugins` * remove "glob" need when updating plugin files * refactor and simply vendors build chain - remove `src/assets/vendors/index.css.html` - remove `src/assets/vendors/index.js.html` - remove `src/index.dev.html` - rename `src/index.prod.html` into `src/index.html` - deprecate config.js variables (`distFolder`, `clientFolder`, `admin_static_folder`, `admin_templates_folder`) - add config.js variable: `admin_overrides_folder` - add gulpfile.js internal variable (`outputFolder`) in order to properly handle `dev` and `build` tasks * reduce delta * update comments * live reload application on plugin.js changes * add comments and sort tasks * handle `build:plugins` task in local development * handle local developed plugins - add parameter `devConfig` within `config.template.js` - deprecate parameter `createProject` within `config.template.js` - deprecate parameter `seCCurrentProject` within `config.template.js` - automatically toggle `skin-blue` class on body tag (dev environment) - refactor function `ApplicationService::obtainInitConfig()` - move `require('app/dev')` into `src/app/main.js` (application entry point) * micro-optimization (single glob watch) * remove mandatory `gid` and `baseurl` options within `G3W_PLUGINS` - convert variable `G3W_PLUGINS` into array (list of locally developed plugins) - automatically assing `gid` and `baseurl` parameter for all locally developed plugins (ref: `src/app/dev/index.js`) * generate `app.min.js.map` (PRODUCTION) - add `gulp-sourcemaps` on production environment * refactor browserify transform option make use of `transform` option instead of chaining transform methods * restore previous plugin developement tips (v3.4) * restore vendors fonts in gulp chain * Update "g3w-admin" and "g3w-suite-docker" badge versions * set v3.5 also on badge image.. * Add some minimal info about "Plugins" development * Align with dev new css and js vendors * Comment change skin color to skin-blue on development environment to has the same color in production * Rename admin_plugins_folder to admin_folder because it referred to g3w_admin folder and not to plugins * Revert "Rename admin_plugins_folder to admin_folder because it referred to g3w_admin folder and not to plugins" This reverts commit 186d37f * Revert "Rename admin_plugins_folder to admin_folder because it referred to g3w_admin folder and not to plugins" This reverts commit 186d37f * replace "comment" section with a TODO * Add deprecate wrapper comment to a part of code to extract project group, type and id parameters to get initial configuration from g3w-admin server Co-authored-by: volterra79 <[email protected]>
Raruto
added a commit
that referenced
this pull request
Feb 7, 2023
…ProjectsRegistry~createProject(projectConfig)` Start addressing: #67 As a result of: #150 we intend to bring the development environment ever closer to the production one. Related to: #89, #292 and g3w-suite/g3w-suite-docker#79
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowserSync already comes with a proxy server, so:
browser-syncproxy server withingulpfile.jsremove uselessdeprecate variableG3W_PROXY_ROUTESwithinconfig.template.jspluginsg3w-admin:pluginsselect-pluginsRefactor and simply vendors build chain:
src/assets/vendors/index.css.htmlsrc/assets/vendors/index.js.htmlsrc/index.dev.htmlsrc/index.prod.htmlintosrc/index.htmlconfig.template.jsvariables (distFolder,clientFolder,admin_static_folder,admin_templates_folder)config.template.js(admin_overrides_folder) andgulpfile.js(outputFolder) in order to properly handledevandbuildtasksHandle local developed plugins:
config.template.js(devConfig)config.template.js(createProject)config.template.js(setCurrentProject)automatically toggleclass="skin-blue"on body tag (dev environment)ApplicationService::obtainInitConfig()andrequire('app/dev')intosrc/app/main.js(application entry point)gidandbaseurloptions withinG3W_PLUGINSG3W_PLUGINSinto array (list of locally developed plugins) (ref.config.template.js)gidandbaseurlparameter for all locally developed plugins (ref:src/app/dev/index.js)More info:
How to test:
Update your
config.jsfile as per516f734:Add the following lines at the top of your
g3w-suite-docker/config/g3w-suite/settings_docker.pyfileRun (and test) the following scripts:
Check that the following rules apply while developing:
Related to #137 and g3w-suite/g3w-suite-docker#62
Close #48 Close #63 Close #75
Partially address: #89